Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of basic search #23

Open
Martinsos opened this issue Mar 30, 2015 · 4 comments
Open

Improve speed of basic search #23

Martinsos opened this issue Mar 30, 2015 · 4 comments

Comments

@Martinsos
Copy link
Owner

Before, in v1.0 branch, opal was 1.5 times faster than now! I have to speed up the parts that I can and isolate all functionalities that are not needed in basic search and are making it slower.

@Martinsos
Copy link
Owner Author

I did not find anything specially useful using profiler: I think I should proceed by:

Martinsos added a commit that referenced this issue Apr 7, 2015
@Martinsos
Copy link
Owner Author

It seems like slowdown in #11 is caused by not breaking from for loop that checks for overflow! If overflow is found and I break from loop when using buckets mode, it will have better time than when not breaking immediately but little bit later. I did not fix this yet, I should explore why this actually has effect on speed that is noticable!

@Martinsos
Copy link
Owner Author

Important: fix I mentioned for #11, it does not seem to help for most of the tests, only for few of them. I will leave the change however.

@Martinsos
Copy link
Owner Author

This fix for #11 makes almost no sense! There is almost no code executed if I do not break so early, so why is there change in performance? I have no idea and that is somewhat frustrating, but I have to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant