Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write in Typescript #107

Open
MartinsOnuoha opened this issue Apr 11, 2022 · 2 comments
Open

Re-write in Typescript #107

MartinsOnuoha opened this issue Apr 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@MartinsOnuoha
Copy link
Owner

  • The idea is to help improve DX (developer experience) when contributing to the project
@MartinsOnuoha MartinsOnuoha self-assigned this Apr 11, 2022
@MartinsOnuoha MartinsOnuoha added the enhancement New feature or request label Apr 11, 2022
@TimAagaard
Copy link
Contributor

I was thinking we could do a rewrite from scratch and call it v1.0

Make it TypeScript, get rid of all the no-longer maintained dependencies (npm lists a bunch on a fresh install), aggregate the data into SQL tables in something like SQLite (it's stored as a local file, so no external DB server) with an ORM like Sequelize that way we could leverage the speedy lookups and filtering of a database (since it will be using B-Trees) instead of filtering JSONs.

would be happy to contrib if you made a fresh new long-term release branch and set up your CI/CD stuff and the hbs stuff doing the front-end portion of the server.

@MartinsOnuoha
Copy link
Owner Author

MartinsOnuoha commented Apr 21, 2022

Hey Tim, yes it absolutely makes sense to aggregate the data into SQL tables in something. and a local file option like SQlite would work since the data wouldn't be growing.

I'll do the initial setup to transition to TS and let you know

@MartinsOnuoha MartinsOnuoha changed the title Enable Typescript in project Re-write in Typescript Apr 21, 2022
@MartinsOnuoha MartinsOnuoha pinned this issue Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants