Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include complete metadata in .json files #10

Open
sschmaus opened this issue Jul 13, 2021 · 10 comments
Open

Include complete metadata in .json files #10

sschmaus opened this issue Jul 13, 2021 · 10 comments
Assignees

Comments

@sschmaus
Copy link

Since the update to metadata handling there are many values now missing from the JSON metadata files.

My workflow for photogrammetry and subsequent animations depends on this information, for example the sclk timer, the CAHVOR camera model and position information.

I would be really helpful to get these values back into the JSON file, preferably just in the old structure or otherwise as a sub-array, so the general structure is still mostly the same.

@kmgill
Copy link
Member

kmgill commented Jul 14, 2021

Yes, I'll be working the metadata values back into it. I'm unifying the metadata across what Mars2020, MSL, and InSight web services provide.

@kmgill
Copy link
Member

kmgill commented Jul 14, 2021

It's good to know you need the data back, so I'll give it a higher priority.

@kmgill kmgill self-assigned this Jul 14, 2021
@sschmaus
Copy link
Author

Thank you.
Its not super urgent, I downgraded a few commits, so for it's working again for me now.

Only when I want to use the any of the new features you are working on, this would really be needed.

@kmgill
Copy link
Member

kmgill commented Apr 28, 2022

Got the stuff in there.

@kmgill kmgill closed this as completed Apr 28, 2022
@sschmaus
Copy link
Author

sschmaus commented May 3, 2022

Sorry for opening this topic up again, but I noticed a few data fields that would make sense to be included as well. Namely these are xyz, date_received and maybe also dimension and sampletype.
The rest is mostly browse related links that shouldn't matter when working with the images.
From my position there is no time pressure to include them though, my current needs are all covered.

@kmgill
Copy link
Member

kmgill commented May 3, 2022

Reopening

@kmgill kmgill reopened this May 3, 2022
kmgill pushed a commit that referenced this issue May 3, 2022
@kmgill
Copy link
Member

kmgill commented May 3, 2022

Added the four recommended fields, as availability allowed.

@sschmaus
Copy link
Author

While working on parsing the rover camera model data I noticed that attitude is still missing from the MRU metadata (this should be the last one missing). This specifies the rover orientation as a quaternion and is kind of important if you want to know how the rover and in result the cameras, are oriented.
It's available on both MSL and M20.

@kmgill
Copy link
Member

kmgill commented Sep 27, 2023

Added attitude field to json metadata files

@sschmaus
Copy link
Author

Thank you! I think the issue is resolved now.

In the long run it would be neat to have all the number values be formatted as numbers instead of strings, but this is not a high priority for me.

Are you planning any changes to the metadata system? I think you mentioned that once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants