Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution of app #26

Open
lyqht opened this issue Feb 4, 2020 · 5 comments
Open

Contribution of app #26

lyqht opened this issue Feb 4, 2020 · 5 comments

Comments

@lyqht
Copy link
Contributor

lyqht commented Feb 4, 2020

Hello! I would like to contribute my streamlit project that was done for a school course!

Website: https://playstore-analytics.herokuapp.com/
Github link: https://github.com/lyqht/googleplaystore-analytics
Please guide me on how to do this and if i should make any revisions, thank you!

@MarcSkovMadsen
Copy link
Owner

Hi @lyqht

That sounds awesome.

If you know how to you can

  • fork this repo
  • add your app to a subfolder of the gallery folder
  • add your app to the apps_in_gallery.py file.

You can see a similar contribution of changes here 77ed2a3.

Just reach out if you need more info or help.

@MarcSkovMadsen
Copy link
Owner

Just took a look at your app. It's really great and would add something a little bit different and inspiring to the gallery. That would help a lot of others.

One suggestion. I think the plots are awesome but they are not interactive. You could consider using something like bokeh/ holoviews/ hvplot, pandas or altair to make them interactive.

I hope you still have the motivation to contribute it. Let me know if you need anything.

@lyqht
Copy link
Contributor Author

lyqht commented Feb 6, 2020

Thanks for a reference contribution! I'll look into the recommendations that you have given me first to make the plots more interactive before making the pull request then. 😃

@MarcSkovMadsen
Copy link
Owner

You are welcome to contribute the app first. Its already very awesome. Then you can improve the plots when and if you have the time and energy. 👍

@lyqht
Copy link
Contributor Author

lyqht commented Feb 6, 2020

Ohh, okay then :D I'll submit the PR soon, thank you for your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants