Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HazelcastSpringBucket4jCacheConfiguration support for SyncCacheResolver #292

Closed
bryanxtong opened this issue Apr 18, 2024 · 1 comment · Fixed by #304
Closed

HazelcastSpringBucket4jCacheConfiguration support for SyncCacheResolver #292

bryanxtong opened this issue Apr 18, 2024 · 1 comment · Fixed by #304
Milestone

Comments

@bryanxtong
Copy link

bryanxtong commented Apr 18, 2024

I have some problems as below

  1. When using cache-to-use “ hazelcast-spring”, HazelcastSpringBucket4jCacheConfiguration should be updated to support SyncCacheResolver and should not be AsyncCacheResolver which will not work
    @Bean @ConditionalOnMissingBean(SyncCacheResolver.class) public SyncCacheResolver hazelcastCacheResolver() { #just for example as below return new HazelcastSyncCacheResolver(hazelcastInstance, false); }

  2. Make changes for Bucket4jCacheConfiguration to include IgniteBucket4jCacheConfiguration for support ignite async and change IgniteCacheResolver#isAsync() return true

  3. Making Changes of the annotation @ConditionalOnCache("jcache-ignite") to @ConditionalOnCache("jcache-infinispan") for InfinispanJCacheBucket4jConfiguration is more clear

@MarcGiffing
Copy link
Owner

Can you please review #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants