Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popups #259

Open
Malvoz opened this issue Aug 10, 2024 · 1 comment
Open

Popups #259

Malvoz opened this issue Aug 10, 2024 · 1 comment

Comments

@Malvoz
Copy link
Member

Malvoz commented Aug 10, 2024

The <properties> element can be used to create popups. It seems to be a case of browser magic, which may not be ideal.

Are authors expected to style the <properties> element itself (or even pseudo-elements) to style popups?

I think it'd be good to consider integration with the new Popover API instead. MapML could specify that HTML should extend the list of allowed popovertarget elements to include <feature>.

@prushforth
Copy link
Member

I think it'd be good to consider integration with the new Popover API instead. MapML could specify that HTML should extend the list of allowed popovertarget elements to include .

+1

Also, I like the idea of <feature> being the one that contains the popover attribute / being the popovertarget i.e. not the <properties> alone, because it might allow the map author to supply CSS that is used when the feature is in the popped-over state to highlight the geometry on the map in some way, while the popover is displayed.

I'll read the MDN docs and see if we can add it to our polyfill roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants