Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Band plot ignores alpha keyword #3356

Open
TomRottier opened this issue Nov 6, 2023 · 5 comments · May be fixed by #3613
Open

Band plot ignores alpha keyword #3356

TomRottier opened this issue Nov 6, 2023 · 5 comments · May be fixed by #3613
Labels
bug CairoMakie This relates to CairoMakie, the vector backend for Makie based on Cairo. good first issue

Comments

@TomRottier
Copy link
Contributor 

    f = Figure()
    ax1 = Axis(f[1, 1], title="alpha = 0.5")
    ax2 = Axis(f[1, 2], title="color = (:red, 0.5)")
    xs = 1:10
    lower, upper = fill(-1.0, 10), fill(1.0, 10)
    band!(ax1, xs, lower, upper, color=:red, alpha=0.5)
    band!(ax2, xs, lower, upper, color=(:red, 0.5))

makie_issue
@TomRottier TomRottier added the bug label Nov 6, 2023
@bguo068
Copy link

bguo068 commented Jan 4, 2024

I had a similar experience. Thanks for the workaround of putting color and alpha together as a tuple

@wsshin
Copy link

wsshin commented Feb 5, 2024

I also had this issue. Thanks for the workaround!

@asinghvi17
Copy link
Member

We should still fix this - people specifying color as e.g. Cycled won't have the option of a color tuple

@asinghvi17 asinghvi17 added good first issue Makie Backend independent issues (Makie core) labels Feb 5, 2024
@SimonDanisch
Copy link
Member

Would just need an alpha here: https://github.com/MakieOrg/Makie.jl/blob/master/src/basic_recipes/band.jl#L14
And then needs to be added to attr here: https://github.com/MakieOrg/Makie.jl/blob/master/src/basic_recipes/band.jl#L56

@asinghvi17 asinghvi17 linked a pull request Feb 7, 2024 that will close this issue
Open
5 tasks
@ffreyer
Copy link
Collaborator

ffreyer commented Feb 19, 2024

Works for me in GLMakie and WGLMakie on master. Doesn't work in CairoMakie

@ffreyer ffreyer added CairoMakie This relates to CairoMakie, the vector backend for Makie based on Cairo. and removed Makie Backend independent issues (Makie core) labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CairoMakie This relates to CairoMakie, the vector backend for Makie based on Cairo. good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow band to pass the alpha attribute to its mesh MakieOrg/Makie.jl
6 participants
@SimonDanisch @wsshin @ffreyer @bguo068 @asinghvi17 @TomRottier