Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGLMakie does not rotate meshscatter objects #3513

Closed
kbarros opened this issue Dec 25, 2023 · 2 comments · May be fixed by #3414
Closed

WGLMakie does not rotate meshscatter objects #3513

kbarros opened this issue Dec 25, 2023 · 2 comments · May be fixed by #3414
Labels
bug WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie.

Comments

@kbarros
Copy link
Contributor

kbarros commented Dec 25, 2023

In the example below, the cylinder appears vertically, but should be oriented horizontally per the rotation keyword. See also #3512 for a problem with the indicator box.

using WGLMakie
fig = Figure()
ax = LScene(fig[1, 1])
marker = Makie._mantle(Point3f(0, 0, -1/2), Point3f(0, 0, 1/2), 1/2, 1/2, 16)
meshscatter!(ax, [Point3f(0, 0, 0)]; color=:blue, markersize=Vec3f(0.1, 0.1, 1), rotation=Point3f(1, 0, 0), marker)
DataInspector(ax)
image
@kbarros kbarros added the bug label Dec 25, 2023
@kbarros kbarros mentioned this issue Dec 25, 2023
Closed
2 tasks
@t-bltg t-bltg added the WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie. label Dec 26, 2023
@SimonDanisch
Copy link
Member

It should be rotations=Point3f(1, 0, 0) ... We really need to clean up this mess better.
See #3414

@SimonDanisch SimonDanisch linked a pull request Dec 28, 2023 that will close this issue
fix bad limits with rotation (no s) attribute #3414
Open
5 tasks
@ffreyer
Copy link
Collaborator

ffreyer commented May 24, 2024

Fixed in 0.21 via #3724

@ffreyer ffreyer closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bad limits with rotation (no s) attribute MakieOrg/Makie.jl
4 participants
@kbarros @SimonDanisch @ffreyer @t-bltg