Have computed var properties also use the queue to add invocations safely #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@navartis @spaluchiewicz looks like you're the most recent committers? Are you reviewing pull requests for this repo? |
maxim-chipeev
approved these changes
Dec 20, 2022
|
Anything I can do to help get this reviewed and merged? |
|
@g-amichnia Hi, I saw you were the second most recent reviewer…would you be so kind as to take a look? |
|
+1 on this. |
|
@spaluchiewicz Would you be able to take a look at this? |
|
Hi. we ran into this issue in our project. Is somebody still going to review this MR? We'd love to have a fix for this issue in an official release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #333