Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid sieve vacation script if reply body includes double quote #3260

Closed
jkolczasty opened this issue May 15, 2024 · 1 comment · Fixed by #3261
Closed

Invalid sieve vacation script if reply body includes double quote #3260

jkolczasty opened this issue May 15, 2024 · 1 comment · Fixed by #3261
Labels
type/bug Bug. Not working as intended

Comments

@jkolczasty
Copy link

Environment & Version

Version: 2.0.41

Description

admin generates invalid sieve script if autoresponder includes " char

Replication Steps

Setup vacation with " in reply message

Observed behaviour

Sieve compile error

Expected behaviour

Sieve vacation response

Logs

Error: sieve: Failed to compile script `dict:proxy:/tmp/podop.socket:sieve;user=***********'
Error: sieve: default: line 63: unexpected character(s) starting with 0xc5
@nextgens nextgens added the type/bug Bug. Not working as intended label May 16, 2024
@nextgens nextgens mentioned this issue May 17, 2024
Merged
2 tasks
@nextgens
Copy link
Contributor

I've got a fix on #3261 ; We are unlikely to backport it though; it will be fixed in the next major release

bors-mailu bot added a commit that referenced this issue May 17, 2024
@bors-mailu @nextgens
Merge #3261
66721f2 
3261: Fix #3260: double-quotes should be escaped/allowed in ooo r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

double-quotes should be allowed in ooo messages

### Related issue(s)
- closes #3260 
- #3249

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <[email protected]>
@bors-mailu bors-mailu bot closed this as completed in 3565ab9 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Bug. Not working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3260: double-quotes should be escaped/allowed in ooo nextgens/Mailu
2 participants
@nextgens @jkolczasty