Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display offsets in hex #160

Open
hut8 opened this issue May 14, 2023 · 2 comments · May be fixed by #161
Open

Option to display offsets in hex #160

hut8 opened this issue May 14, 2023 · 2 comments · May be fixed by #161

Comments

@hut8
Copy link

hut8 commented May 14, 2023

It would be super great if these offsets could optionally be displayed in hex rather than decimal:

image

I'll try to get to this myself!

@hello-adam
Copy link
Member

I would be happy to pull this in if you added it. I think you would do the hex text rendering somewhere in here: https://github.com/Mahlet-Inc/hobbits/blob/master/src/hobbits-widgets/displayhelper.cpp#L298

And then if you wanted per-display toggles, you'd need to add a control for that in each display plugin's AbstractParameterEditor implementation: https://github.com/Mahlet-Inc/hobbits/blob/master/src/hobbits-plugins/displays/Hex/hexform.cpp

and then a way to read and use that parameter configuration: https://github.com/Mahlet-Inc/hobbits/blob/master/src/hobbits-plugins/displays/Hex/hex.cpp#L12

Or, as a lazy option, you could make it a global setting (src/hobbitscore/settings*)

@hut8
Copy link
Author

hut8 commented May 18, 2023

Oh wow, thanks for the guidance! Very much appreciated. I'll get to this ASAP

@hut8 hut8 linked a pull request May 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants