Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Start possibility #3442

Open
bugsounet opened this issue May 7, 2024 · 8 comments
Open

Crash on Start possibility #3442

bugsounet opened this issue May 7, 2024 · 8 comments

Comments

@bugsounet
Copy link
Contributor

I just see crash possibility:

  • if module: is missing in module configuration object
  • module configuration object is empty

crash return:

[2024-05-07 12:54:10.972] [ERROR] (node:18916) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'split')
    at loadModule (/home/bugsounet/MagicMirror/js/app.js:156:27)
    at loadModules (/home/bugsounet/MagicMirror/js/app.js:213:10)
    at async App.start (/home/bugsounet/MagicMirror/js/app.js:261:3)
(Use `electron --trace-warnings ...` to show where the warning was created) 

I will see to patch it

@sdetweil
Copy link
Collaborator

sdetweil commented May 7, 2024

but a few modules in defaults don't have config object.. why now?

@sdetweil
Copy link
Collaborator

sdetweil commented May 7, 2024

Screenshot_20240507_070005_Chrome

@bugsounet
Copy link
Contributor Author

bugsounet commented May 7, 2024

no, no sam
I says this possiblity:

		{
			//module: "clock",
			position: "top_left"
		},

or

		{
                    /*
			module: "clock",
			position: "top_left"
                   */
		},

Or again

		{
			Module: "clock",
			position: "top_left"
		},

for example

if this is no module: in object definition : MM³ crash on start

@sdetweil
Copy link
Collaborator

sdetweil commented May 7, 2024

oh..

I thought you meant

config:{}

@bugsounet
Copy link
Contributor Author

should we correct this issue?

@sdetweil
Copy link
Collaborator

sdetweil commented May 8, 2024

yes.. never crash

@bugsounet
Copy link
Contributor Author

never crash, no issue about this, so it's not needed ;)

@sdetweil
Copy link
Collaborator

sdetweil commented May 8, 2024

I dont understand. we should never crash from users mistakes.
so anytime we find one we should fix it. like this

yes it's needed to.prevent crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants