Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to choose between different youtubers #46

Closed
olivertzeng opened this issue Sep 2, 2023 · 10 comments
Closed

Add an option to choose between different youtubers #46

olivertzeng opened this issue Sep 2, 2023 · 10 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@olivertzeng
Copy link

There are too many YouTubers out there that are too suitable for clickbait thumbnails(for example DistroTube) So I think that you can make a preference of choosing different YouTubers and let different GitHub users commit the thumbnail database of the YouTubers they want.

@JxxIT
Copy link
Contributor

JxxIT commented Sep 2, 2023

Good idea! Maybe we could combine it with #44

@olivertzeng
Copy link
Author

olivertzeng commented Sep 2, 2023

Cool!
This rap battle is brought you by keeps

@MagicJinn MagicJinn self-assigned this Sep 2, 2023
@MagicJinn MagicJinn added the wontfix This will not be worked on label Sep 2, 2023
@MagicJinn
Copy link
Owner

I think different youtubers work best as separate extensions. There are already many alternate versions of this add-on on the chrome and firefox webstore, and I've done my best to make creating your own as easy as possible! Adding alternative youtubers to the files of this extension would cause it to surpass 100MB which is very unusual for a browser extension.

@olivertzeng
Copy link
Author

Is there a wiki for this? @MagicJinn

@MagicJinn
Copy link
Owner

There is not currently, but I can tell you how:

  1. Download the code, either by cloning the repository if you want to use version control, or just downloading it as a zip
  2. Delete all images
  3. Add new images. Leave no gaps in the images, so don't do 1.png, 2.png, 4.png.
  4. If you don't have images with text on them, skip to step 7 and delete flip_blacklist.json
  5. Add flipped images to the textFlipped folder (if you have them)
  6. Edit flip_blacklist.json with the numbers of the images that should be flipped, or set useAlternativeImages to false
  7. Continue to follow the steps in this issue

@olivertzeng
Copy link
Author

There is not currently, but I can tell you how:

  1. Download the code, either by cloning the repository if you want to use version control, or just downloading it as a zip
  2. Delete all images
  3. Add new images. Leave no gaps in the images, so don't do 1.png, 2.png, 4.png.
  4. If you don't have images with text on them, skip to step 7 and delete flip_blacklist.json
  5. Add flipped images to the textFlipped folder (if you have them)
  6. Edit flip_blacklist.json with the numbers of the images that should be flipped, or set useAlternativeImages to false
  7. Continue to follow the steps in this issue

cool
so the .pngs in step 3 are the pictures without the background, only the person & the text right?

@MagicJinn
Copy link
Owner

Yes! Only a transparent image of the youtuber

@olivertzeng
Copy link
Author

ok but how do i remove unnessisery text on them? and how about those arrows?

@MagicJinn
Copy link
Owner

MagicJinn commented Sep 3, 2023

For that you'd have to use photo editing programs. Easy to use online tools include clipdrop and photoroom background remover.

@olivertzeng
Copy link
Author

Cool! I'll look into that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants