Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for Delphes in Jet-Substructure module #208

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Bugfix for Delphes in Jet-Substructure module #208

merged 7 commits into from
Jul 21, 2023

Conversation

jackaraz
Copy link
Member

Context:
This PR is to prevent delphes from crashing for the substructure module.

Description of the Change:
Added fastjet flags during delphes compilation

Possible Drawbacks:
This may cause further issues due to miscommunication between modules

Related GitHub Issues:
See issue #204

@jackaraz jackaraz requested a review from BFuks July 19, 2023 09:45
@github-actions
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@jackaraz jackaraz linked an issue Jul 19, 2023 that may be closed by this pull request
Delphes raises seg-fault in substructure branch #204
Open
@jackaraz jackaraz added 🐛bug Something isn't working Delphes Delphes interface FastJet Issues regarding FastJet labels Jul 19, 2023
@BFuks BFuks marked this pull request as ready for review July 19, 2023 12:29
BFuks
BFuks requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@BFuks BFuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jack. Could you please try with the extra commits I made?

@jackaraz jackaraz marked this pull request as draft July 20, 2023 09:04
@jackaraz jackaraz changed the title add fastjet flags for delphes Bugfix for Delphes in Jet-Substructure module Jul 20, 2023
@jackaraz jackaraz requested a review from BFuks July 21, 2023 14:11
@jackaraz jackaraz marked this pull request as ready for review July 21, 2023 14:13
BFuks
BFuks approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@BFuks BFuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably OK. I run a few tests and they pass.

@jackaraz jackaraz merged commit d1608aa into substructure Jul 21, 2023
1 check passed
@jackaraz jackaraz deleted the delphes_bugfix branch July 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BFuks BFuks BFuks approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working Delphes Delphes interface FastJet Issues regarding FastJet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delphes raises seg-fault in substructure branch
2 participants
@jackaraz @BFuks