-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessary dependencies to run full validation vs. validation with just ROOT #179
Comments
HI @matthewfeickert, thanks for the effort! Our testing is not fully functioning on GitHub yet, but we do end-to-end validation in HPC before releases (thats why we release new versions very slowly...). Need more men power to implement unit tests so that it's easier with GitHub. But whenever you compile MadAnalysis it does set of basic tests where it basically makes sure that everything is accessible. |
Following some success with HEPData/hepdata_lib#220 I'm trying to setup some CI on my fork (to PR) that would run a full validation as compared to
.github/workflows/quick_validation.yml
which seems to be only be taking a few seconds and so not actually testing things. Conversely, when I ranon my local machine in my dev area a huge amount of log activity and downloading started to happen, which was running for a bit before I killed it as I wasn't quite clear what it was actually doing.
The requirements are listed as
madanalysis5/README.md
Lines 46 to 67 in 65d4239
but Delphes is also
madanalysis5/README.md
Line 238 in 65d4239
To get all the dependencies to fully test MA5 I would assume one needs all of these, and so Issue #2 / PR #12 would need to also include additional software like LaTeX, FastJet, and Delphes. As FastJet and Delphes aren't on conda-forge I don't think that micromamba is going to be able to make things as easy as it did for
hepdata-lib
, but are there a subset of tests that could be run that go beyond the quick validation with ROOT and LaTeX?The text was updated successfully, but these errors were encountered: