Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not put plots under version control #134

Open
rmcdermo opened this issue Apr 1, 2023 · 1 comment
Open

Do not put plots under version control #134

rmcdermo opened this issue Apr 1, 2023 · 1 comment

Comments

@rmcdermo
Copy link
Contributor

rmcdermo commented Apr 1, 2023

@leventon Why are these png files under version control?

People are starting to actually use this repo now. We need to get this stuff in order. If you need to add Jupyter notebooks to show plots from data, then do so. But do not commit png files.

@rmcdermo
Copy link
Contributor Author

rmcdermo commented Apr 1, 2023

I added a new tag v0.0.0-figures. If you want, you can create a release with this tag and put any figures you need here, then link to them. I also created a similar tag for macfp-db-figures. We should begin migrating all the images for macfp-db over to that release. (Should have done this right at the beginning, but now this is becoming a problem, so we should clean it up.)

I am not suggesting you overhaul all figures right now. This issue pertains directly to plots made from data. These plot should not be under version control. If you want to identify the plot with a commit, then add a tag to the plot that indicates the commit of the data used for the plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant