Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up class vs. passed variables: update_z_ext_external_upstream: Update S0 or Q_s_0? #13

Open
awickert opened this issue Oct 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@awickert
Copy link
Collaborator

The structure within the Network-module function, update_z_ext_external_upstream(self, S0=None, Q_s_0=None), is implemented with the variables in question being passed externally as well as from the class variables. If Q_s_0 be set, then S0 will be, and this can also lead to some unintended behavior that I've lightly patched over.

The redundancy between S0 and Q_s_0 leads this code to be unclear about which should be updated to provide a change in the upstream boundary condition on a river.

This function should be updated to manage both class vs. passed variables and to make clear which variable (S0 or Q_s_0) has primacy in defining the upstream boundary: which defines the other (or is defined by the other) in which situation? This might require some reworking of the use of class variables (maybe these passively remain internal) and passed variables (from an external driver), but this is just a first idea.

@awickert awickert added the bug Something isn't working label Oct 16, 2023
@awickert awickert added this to the v2.0 milestone Oct 16, 2023
@awickert awickert self-assigned this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant