-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in ggl90/IDEMIX code? #665
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In pkg/ggl90/ggl90_calc.F,
recip_hFacI
(inverse cell thickness of w-cells) is used a few times to scale variables and coefficients, but only whenuseIDEMIX=.TRUE.
. Two places, where I think this is wrong are:MITgcm/pkg/ggl90/ggl90_calc.F
Lines 696 to 697 in 1575dc0
because
verticalShear
is also used to compute the Ri-number, wheresigmaR
has been computed without takinghFac
s into account (grad_sigma.F). So in my view it would be consistent to not scaleverticalShear
withrecip_hFacI**2
and
MITgcm/pkg/ggl90/ggl90_calc.F
Lines 831 to 842 in 1575dc0
The implicit solver code was initially more or less a copy of
impldiff.F
, so I think that the GGL90 code is consistent with how we do things in general (i.e. only userecip_drF*recip_hFacC
but notrecip_hFacI
withrecip_drC
).As a consequence
verticalShear
can be too large near the bottom leading to too much forcing, and similarly for the coefficientsa3d
andc3d
. Any opinions are welcome.The text was updated successfully, but these errors were encountered: