Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydrogenbond analysis should check for missing bonds in the same way as the serial code #118

Open
orbeckst opened this issue Mar 9, 2020 · 0 comments
Open

hydrogenbond analysis should check for missing bonds in the same way as the serial code #118

orbeckst opened this issue Mar 9, 2020 · 0 comments
Assignees
@VOD555
Milestone
0.4

Comments

@orbeckst
Copy link
Member

orbeckst commented Mar 9, 2020 •
edited
Loading

The PMDA version of the new h-bond analysis code

  • raises ValueError
  • check u.bonds

The serial version

  • raises NoDataError
  • checks u._topology.bonds

in PR MDAnalysis/mdanalysis#2572

This came out of discussion in MDAnalysis/mdanalysis#2396 (comment) and the PMDA version should do the same for performance and consistency.
@orbeckst orbeckst added this to the 0.4 milestone Jul 15, 2020
@VOD555 VOD555 mentioned this issue Jul 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VOD555 VOD555

Labels
None yet
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@orbeckst @VOD555