Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layout customization support #43

Closed
wants to merge 2 commits into from
Closed

Add layout customization support #43

wants to merge 2 commits into from

Conversation

zekker6
Copy link

@zekker6 zekker6 commented Feb 12, 2023

Thanks for this app!
I wanted to have dark theme to use, so ended up implementing it :)

Here are a few examples of how it looks like:

  • Your profile
    Your profile
  • gamersforever1695 (a contributor here)
    gamersforever1695

@vercel
Copy link

vercel bot commented Feb 12, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @LordDashMe on Vercel.

@LordDashMe first needs to authorize it.

@LordDashMe
Copy link
Owner

This is cool! 👍 let us review it further.

Thanks @zekker6!

@LordDashMe LordDashMe linked an issue Feb 13, 2023 that may be closed by this pull request
Layout Customization #7
Open
@LordDashMe LordDashMe changed the title feat: add dark theme support Add layout customization support Feb 13, 2023
@LordDashMe
Copy link
Owner

Hi, @zekker6, I think we are near to do the all customizable thing. Can we make the following items to be more customizable via query params?

  • background
    • fill
    • stroke
  • title
  • stats
  • rating
  • icons

So the URL will be something like:

?username=zekker6&backgroundFill=#000&...

@zekker6
Copy link
Author

zekker6 commented Feb 13, 2023 •
edited

@LordDashMe Thanks for review, implemented this.
It allows to specify hex code for color.

test

backgroundFill: fff
test

@zekker6
Copy link
Author

zekker6 commented Feb 27, 2023

@LordDashMe Just a reminder this one needs some review and probably merge if it looks good to you

@LordDashMe
Copy link
Owner

@LordDashMe Just a reminder this one needs some review and probably merge if it looks good to you

Alright! LGTM, but let us review it further. Thanks @zekker6 👍

@LordDashMe LordDashMe changed the base branch from master to 1.1.0 February 28, 2023 17:57
@MrBartusek
Copy link

@LordDashMe any update on this?

@LordDashMe
Copy link
Owner

@LordDashMe any update on this?

Thanks for the interest with this feature PR, there are an ongoing reviews and plan to release this feature. So hold tight, it will be push to production soon. ☺️

@LordDashMe LordDashMe deleted the branch LordDashMe:1.1.0 April 1, 2024 15:49
@LordDashMe LordDashMe closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordDashMe LordDashMe Awaiting requested review from LordDashMe

@gamersforever1695 gamersforever1695 Awaiting requested review from gamersforever1695

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout Customization
3 participants
@zekker6 @LordDashMe @MrBartusek