Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results makes the main UI jump around #30

Open
ctsstc opened this issue Nov 4, 2021 · 1 comment
Open

Search results makes the main UI jump around #30

ctsstc opened this issue Nov 4, 2021 · 1 comment
Assignees
Labels
UI User Interface

Comments

@ctsstc
Copy link
Member

ctsstc commented Nov 4, 2021

It's due to the word wrapping on the song names most commonly.

Likely need to prevent wrapping on the artist name as well potentially.

It is really nice to see the full name, so maybe we should default them to a max of 2 lines and then do an overflow? That might make the UI too tall though, maybe we need to go back to 5 results at that point?

image

@ctsstc ctsstc added the UI User Interface label Nov 7, 2021
@ctsstc
Copy link
Member Author

ctsstc commented Nov 7, 2021

Maybe there's some fancy flexbox helper that could help space these out too. I'm also trying to think about responsive design here as well since we'll likely want dynamic width that can wrap around and be read on mobile. Do we need a fixed height on the parent and let the children spread and ellipsis as needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface
Projects
None yet
Development

No branches or pull requests

2 participants