Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Safari extension #85

Open
4 tasks done
DaniruKun opened this issue Jun 23, 2022 · 6 comments
Open
4 tasks done

[Feature]: Safari extension #85

DaniruKun opened this issue Jun 23, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@DaniruKun
Copy link
Member

Checklist

  • This is an issue for Hyperchat, not LiveTL. I will go to the LiveTL repo to report an issue for LiveTL.
  • I have checked for a duplicate or similar issue. I made sure to check closed issues as well.
  • I am not reporting a bug. If I am, I will use the bug report issue template.
  • By submitting this issue, you agree to follow our Code of Conduct

Is your feature request related to a problem? Please describe.

As a Safari user like many others, it would be great if HyperChat was available on Safari as well (both desktop and mobile).

Describe the solution you'd like

A Safari extension ported from the Chrome one, that would also make it work on Safari on iOS and iPadOS.

Expected behavior

Working Safari extension on:

  • Safari desktop
  • Safari iOS
  • Safari iPadOS

Describe alternatives you've considered

No response

Anything else?

https://developer.apple.com/documentation/safariservices/safari_web_extensions/converting_a_web_extension_for_safari

@DaniruKun DaniruKun added the enhancement New feature or request label Jun 23, 2022
@Candygoblen123
Copy link
Member

I suppose I can try to compile it again, but no promises.

@Candygoblen123
Copy link
Member

Alright, I've made a TestFlight for HyperChat on Safari (macOS only right now), available here: https://testflight.apple.com/join/9mAUz2gp

There's a few issues, but it should be relatively easy to iron out the kinks.

@Candygoblen123 Candygoblen123 self-assigned this Jun 24, 2022
@DaniruKun
Copy link
Member Author

I'll try to give it a try today, thanks!

@DaniruKun
Copy link
Member Author

DaniruKun commented Jun 26, 2022

Since TestFlight feedback is too small:

Some comments:

  • Opening HyperChat Settings launches the settings window in fullscreen, which I think is not desired behaviour?
  • It seems HC does not work on VODs at all (not a single chat is loaded, see attached screenshots)
  • On lives, HC only loads a set of chats and then stops (see screenshots). Disabling and reenabling doesn't help.

image

image

Environment:

Safari Version 15.5 (17613.2.7.1.8)

@Candygoblen123
Copy link
Member

The Live chat issue is known.

As for archives, they should work perfectly, but LiveTL and Hyperchat will conflict is you have them both installed, please uninstall LiveTL for now.

Also for settings, I'm thinking of just opening a new tab instead, mostly for iOS compatibility.

@DaniruKun
Copy link
Member Author

Yeah other than the live chat issue it seems to function ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants