New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

吐槽一手 #6

Open

shenjackyuanjie opened this issue Feb 10, 2023 · 1 comment

shenjackyuanjie commented Feb 10, 2023

首先，对这个代码质量，我就不说了

看您的项目目录，看起来也不像是主要写py的

大部分 py 文件前面都有不知所措的空行，不带任何说明，也不带任何 import
可以参考PEP8，拿个代码格式化工具格式化一下吧
感觉就是像用写shell脚本的想法去写py，但是py他也是个语言啊，本来可以压缩成一行的东西很多地方都写了一大堆
而且写了一大堆的地方并不能让你的代码逻辑变清晰，反而冗长
每个文件都有一个主函数，然后主函数会递归调用自己
对于这种操作，我很好奇为什么不用while true和break
刚想到这么多，就先写这么多吧

Owner

LinWin-Cloud commented Feb 10, 2023

这个代码我现在看来确实恶心，你说的没错。这个项目以前还维护，现在不维护了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment