Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong case of class variable inside TinyCIFAR10DataModule #1001

Open
ggalan87 opened this issue Apr 19, 2023 · 0 comments
Open

Wrong case of class variable inside TinyCIFAR10DataModule #1001

ggalan87 opened this issue Apr 19, 2023 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ggalan87
Copy link

🐛 Bug

Prior to utilization of TinyCIFAR10DataModule I did a check on its (under review) code. Ι realized that there is a bug/typo inside __init__, where self.extra_args variable is set:

self.extra_args = dict(num_samples=self.num_samples, labels=self.labels)

This is in contrast to self.EXTRA_ARGS which is already defined and used by the methods of the base class as required to pass the correct extra arguments to the underlying dataset:

dataset_train = self.dataset_cls(self.data_dir, train=True, transform=train_transforms, **self.EXTRA_ARGS)
dataset_val = self.dataset_cls(self.data_dir, train=True, transform=val_transforms, **self.EXTRA_ARGS)

A similar case that self.extra_args is used is inside CityscapesDataModule, however there the implementation is self-contained and does not depend on base class for train_dataloader and test_dataloader.

Besides the bug, is there a motivation about why a capitalized version of the variable was preferred inside VisionDataModule?

@ggalan87 ggalan87 added the help wanted Extra attention is needed label Apr 19, 2023
@Borda Borda added fix fixing issues... bug Something isn't working and removed fix fixing issues... labels Jun 20, 2023
@Borda Borda changed the title Wrong case of class variable inside TinyCIFAR10DataModule Wrong case of class variable inside TinyCIFAR10DataModule Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants