You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a user only specifies the dir and does specify save_dir, the current implementation ignores dir because save_dir is not None (set to . by default). The priority should be 1. Use save_dir if provided, 2. Use dir if save_dir is not present. 3. Use . which is the default.
If this is not a duplicate of an issue and the workflow is expected as described above, let me know and I will be interested in creating a PR to fix this.
Bug description
The
save_dir
param is set to.
by default and henceif save_dir is not None:
is always False.https://github.com/Lightning-AI/pytorch-lightning/blob/d1949766f8cddd424e2fac3a68b275bebe13d3e4/src/lightning/pytorch/loggers/wandb.py#L327C12-L327C20
When a user only specifies the
dir
and does specifysave_dir
, the current implementation ignoresdir
becausesave_dir
is not None (set to.
by default). The priority should be 1. Usesave_dir
if provided, 2. Use dir ifsave_dir
is not present. 3. Use.
which is the default.If this is not a duplicate of an issue and the workflow is expected as described above, let me know and I will be interested in creating a PR to fix this.
What version are you seeing the problem on?
v2.1
How to reproduce the bug
Error messages and logs
Environment
Current environment
More info
No response
The text was updated successfully, but these errors were encountered: