Make submit visible but disabled before input is given, fixes #677 #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change I've made here is adding a 'disabled' styling to the DeprecatedButton component, which desaturates it and lowers the opacity, visually indicating that it's disabled.
Then within the ChallengePanel component I've made it so that the submit button appears disabled if no input has been given, appear enabled if input has been given, and disappear when the 'continue' button is available.
My reason for the latter part was that it allows users to press submit and then click again in the same place to continue, which is the natural next interaction.
I updated the feature files to reflect the new expected behavior.
(This is my first PR for LL, I really like the project, let me know if there's anything I should change)