Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTCG] Implement a way to map group types to spec's supported token types #9

Closed
apresmoi opened this issue Dec 2, 2022 · 1 comment

Comments

@apresmoi
Copy link
Collaborator

apresmoi commented Dec 2, 2022

As pointed out in #8 we should make the following fixes on the mapping of group types to token types:

Group Type Token Type Reason
spacing dimension
radius string Actually this could be dimension, but we also have to support % and currently there isn't support for that in the spec
mediaQuery dimension
fontSize dimension
letterSpacing dimension
lineHeight dimension

Example:
Screen Shot 2022-12-02 at 11 20 36

That should look something like:

{
  "Spacing": {
    "$type": "dimension",
    "tokens": {
      "small": {
        "$value": "4px"
      },
      "medium": {
        "$value": "8px"
      },
    }
  }
}

@apresmoi apresmoi changed the title Implement a way to map group types to spec's supported token types [DTCG] Implement a way to map group types to spec's supported token types Dec 2, 2022
@apresmoi
Copy link
Collaborator Author

This was solved in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant