Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain track size when changing unit #12

Open
patak-dev opened this issue Sep 22, 2020 · 2 comments
Open

Maintain track size when changing unit #12

patak-dev opened this issue Sep 22, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@patak-dev
Copy link
Member

When you change a unit, the size is updated to 1fr, 300px, 10%, 4em. We should try to compute a new value for the track size that gives the same approximate size, but with the new unit. It doesn't need to be exact.

@patak-dev patak-dev added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Good issue for Hacktoberfest labels Sep 22, 2020
@patak-dev patak-dev removed the Hacktoberfest Good issue for Hacktoberfest label Dec 4, 2020
@abeledovictor
Copy link
Contributor

Can we use Polished for this enhancement? For em and rem at least, and for percentages maybe we can do the calc getting the container width.

@patak-dev
Copy link
Member Author

Interesting @abeledovictor, that is an option. We could also check how that utility is implemented, maybe it is a one liner that we can include in our utils and avoid the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants