Fix video thumbnail override issue #2474
Conversation
|
I made a few other thumbnail related changes while I was at it. Thumbnails now always show up, even on mobile: I did this because I noticed that videos were unviewable on mobile unless I clicked the post title once to navigate to the post page, then again to actually see the video. Here is a video post on mobile on the main branch: As you can see, you can't tell this is a video by looking at it. Finally, always including the thumbnail, even for text-only posts, keeps posts on the feed a consistent height, which I personally think looks better. |
.npmrc
Outdated
| @@ -0,0 +1 @@ | |||
| ignore-scripts=true | |||
There was a problem hiding this comment.
I started getting an error about an opencollective postinstall script when I tried to install. Without ignoring scripts now, you can't install dependencies. This only started happening at the time I post this and I'm not sure why.
Seems fine to me. I'll fix the merge conflicts. |
Fixes #2418. Here is what it looks like now:
I made as few changes to the logic as I could. I'm afraid to touch it, especially since we don't have any tests set up. This makes me want to work on the leptos UI rewrite even more than I already do.