Skip to content
This repository has been archived by the owner on Mar 28, 2022. It is now read-only.

Labels don't show on Leaflet 1.0b1 #121

Open
trakais opened this issue Jul 15, 2015 · 13 comments
Open

Labels don't show on Leaflet 1.0b1 #121

trakais opened this issue Jul 15, 2015 · 13 comments

Comments

@trakais
Copy link

trakais commented Jul 15, 2015

@Leaflet says this plugin needs update to be supported in Leaflet 1

@snkashis
Copy link
Member

I have a preliminary b1 branch up @ master...snkashis:b1_compat . What problems are you seeing so far? I do see labels falling below polygons.

@snkashis
Copy link
Member

Took care of that with a z-index bump up to 500.

@snkashis
Copy link
Member

And yeah, I see how there is an issue with whenReady callback on L.map.

@snkashis
Copy link
Member

2.2-dev appears to be fine with b1... because of cead0a6

@danzel
Copy link
Member

danzel commented Aug 26, 2015

From testing locally we needed to always redraw on viewreset.
I've pushed up a branch here:
https://github.com/Leaflet/Leaflet.label/tree/leaflet-master

@yohanboniface
Copy link
Member

@danzel I see you have started a branch for 1.0 compat, what about pulling out #122 on there too?

@danzel
Copy link
Member

danzel commented Aug 30, 2015

Thanks, hadn't seen that one, will do and tidy up.

@benglass
Copy link

great library!

👍 any progress on a stable release or consolidated branch for leaflet 1 support?

@a1an77
Copy link

a1an77 commented Nov 13, 2015

Same problem here with 1.0b2, how can I hotfix it until a release comes? Thanks

@danzel
Copy link
Member

danzel commented Nov 16, 2015

use the leaflet-master branch, you'll need to build the js yourself.

Run npm install and then jake (iirc)

@PikachuEXE
Copy link

The bower.json on that branch seems not updated yet

@smitchell
Copy link

I just tried the preliminary branch with Leaflet hotline, and when I pulled it L.hotline was undefined. Not sure whats up with that. http://exploringspatial.com/#demo/10 I've removed Label from the demo for now.

@plmarko
Copy link

plmarko commented Jun 9, 2016

Hi,

The issue with whenReady callback on L.map. still exists if you get package using npm install leaflet-label. I've seen the fix in the cead0a6 but probably you forgot to bump up the version with this fix . Ver 0.2.2-dev on npm still has some old code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants