-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we move to a src and dist directory structure? #59
Comments
👍 |
Maybe also auto generating the shy version is a good idea as well. |
As someone trying to parse the bliss code for the first time, |
@LeaVerou What do you think about this. I was also wondering if we should separate the actual code development to a |
I'm a fan of both |
I have this issue with most of my projects, so I would definitely welcome a solution :( 👍 to @guoguo12, yes, if we keep everything in the same dir, moving the website js files to a folder is probably a good idea. @kurtextrem Not sure what you mean. bliss.shy.js is the source, bliss.js is auto-generated. |
Could just have the source in |
@LeaVerou can we not have the download links point to the raw.github... of the generated files on master? |
@zdfs Then it's yet another manual step, that I'd rather avoid. Also, I'd rather have the current version on the website, not the last "release". |
Ok. So let's define what we have so far.
|
@LeaVerou curious why that's discouraged. Anything other than DNS lookup issue? |
I think that sums it up. I also suggested moving the website JS files into a separate subdirectory, but that can be addressed later. @zdfs: Updated. |
Should I wait until we decide on this before I start tagging releases? |
@LeaVerou - We can start tagging, that won't get in the way of anything. I'm just attempting to try and find a holistic solution we can all execute on. |
I think we have most of our criteria.
Ideas. Suggestions. The floor is open. |
Isn't 4 tied to 1? If releases are being tagged, I can just npm publish, no? @zdfs: Updated. |
you could link to the latest version on master from the that way |
You may need to use a service like RawGit in order to have the script run on the page. GitHub does not return the right headers when embedding a script from the raw URL, but RawGit gets around that. |
Relying on a third party service like rawgit makes me a bit uneasy. |
@LeaVerou - Domenic has something like this: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd |
Any consensus on this? @zdfs: I like the Domenic script provided that it can be set up easily. |
There are things we can try, but no work has started. I guess we could make a |
I am here! |
Ok. Just so we can make some progress on this story. I'm going to branch |
i'm available too for testing or helping :) |
Ok. Branch is made. |
@zdfs - Yep. But if I do something stupid, you would know! :) I have cloned the branch and pushed it to mine now. Should I go ahead and make those directory and gulp changes? |
do we need to make a slack or something. |
I can do that. |
I made a Slack instance at https://blissjs.slack.com/. |
Says I am not in that team. This email - [email protected] ? |
I'll take a look and send out invites. |
Closing this for #82. |
It's not high priority but right now even changing the gulp file triggers the watch. It would probably be better to move the src in src directory and generated files in dist directory?
The text was updated successfully, but these errors were encountered: