Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email validation #503

Merged
merged 9 commits into from
Aug 31, 2023
Merged

add email validation #503

merged 9 commits into from
Aug 31, 2023

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Aug 29, 2023

Copy link
Member

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Excellent docs here @pxpm . My only real note here is regarding paragraphing. So I'm not going to merge myself, I'll let you do it to see WHY I suggest these things.

6.x/base-how-to.md Outdated Show resolved Hide resolved
6.x/base-how-to.md Outdated Show resolved Hide resolved
6.x/base-how-to.md Outdated Show resolved Hide resolved
6.x/base-how-to.md Outdated Show resolved Hide resolved
6.x/base-how-to.md Outdated Show resolved Hide resolved
6.x/base-how-to.md Outdated Show resolved Hide resolved
6.x/base-how-to.md Outdated Show resolved Hide resolved
Co-authored-by: Cristian Tăbăcitu <[email protected]>
@tabacitu
Copy link
Member

Xnapper-2023-08-31-09 59 10

pxpm and others added 5 commits August 31, 2023 09:02
Co-authored-by: Cristian Tăbăcitu <[email protected]>
Co-authored-by: Cristian Tăbăcitu <[email protected]>
Co-authored-by: Cristian Tăbăcitu <[email protected]>
Co-authored-by: Cristian Tăbăcitu <[email protected]>
Co-authored-by: Cristian Tăbăcitu <[email protected]>
6.x/base-how-to.md Outdated Show resolved Hide resolved
@tabacitu tabacitu merged commit 947eba8 into master Aug 31, 2023
1 check passed
@tabacitu tabacitu deleted the docs-for-email-validation branch August 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants