Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload multiple selection display #5664

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Sep 17, 2024

WHY

fixes: #5623

BEFORE - What was wrong? What was happening before this PR?

When deleting all previous files from the input and selecting some new files to be uploaded, the new selected files wouldn't be displayed in the UI, making developers think the files may not have been selected, when they actually were selected.

AFTER - What is happening after this PR?

We properly initialize the container, so the selected files show on the UI.

HOW

How did you achieve that, in technical terms?

Updated the selector and re-initialized the existingFiles variable on each file change.

Is it a breaking change?

No

How can we test the before & after?

1. Add a few files and save.
2. Go to edit, **remove all files**, do not save, and select a few new files to update.
  - You will notice that no new file selection is being reflected on the GUI (if you remove a few, not all, then the selection GUI will reflect fine.)
  - But when you click save, new files are saved without any issue and displayed perfectly.

@pxpm pxpm merged commit 7d0b79c into main Sep 17, 2024
9 checks passed
@pxpm pxpm deleted the fix-upload-multiple-file-selection branch September 17, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Multiple Upload does not select images after deleting all previous selected
1 participant