Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 multilevel menu items #5268

Closed
pxpm opened this issue Aug 7, 2023 · 5 comments
Closed

V6 multilevel menu items #5268

pxpm opened this issue Aug 7, 2023 · 5 comments

Comments

@pxpm
Copy link
Contributor

pxpm commented Aug 7, 2023

Discussed in Laravel-Backpack/community-forum#614

Originally posted by froid24 August 4, 2023
Hi guys,

I saw a lot of talk about having multiple levels for the menu in previous versions (where a submenu option can have a submenu of its own). Where can I find an example of how it is done in V6 (Tabler)?

Also, at some point menu options not having any suboptions were automatically hidden. is this not the case anymore? Because that was really nice.

Thank you!

@pxpm pxpm transferred this issue from Laravel-Backpack/community-forum Aug 7, 2023
@pxpm pxpm added Possible Bug A bug that was reported but not confirmed yet. Priority: MUST Priority: SHOULD labels Aug 7, 2023
@pxpm
Copy link
Contributor Author

pxpm commented Aug 7, 2023

@karandatwani92 investigated and Tabler support multi-level menu, unfortunately our menu components don't. Laravel-Backpack/community-forum#614 (comment)

@tabacitu
Copy link
Member

tabacitu commented Aug 9, 2023

I would love to have this too ❤️ Not sure how we can implement it though. And if we do... is it a Tabler feature only or should we add it to ALL themes? Food for thought.

@karandatwani92 karandatwani92 moved this to In Progress in This week Aug 10, 2023
@karandatwani92 karandatwani92 added the Size: S 1 day label Aug 11, 2023
@karandatwani92 karandatwani92 moved this from In Progress to Todo in This week Aug 11, 2023
@karandatwani92
Copy link
Contributor

karandatwani92 commented Aug 11, 2023

@tabacitu @pxpm I investigated more. This can't be done in CRUD repo(with a common code).
if I'm right, I saw all themes already have their menu views & classes individually to render the menu.
So this would also be done per theme level.

Also, BS4 & BS5 don't support a 3-level menu natively but custom CSS helps implement this.

  • I saw the Tabler demo has it.
  • I saw the core UI 4.3 demo have it.
  • Core Ui 2/Bootstrap 4 can have it with custom code too.

@tabacitu how we should proceed? what should be the priority?

One question I have: Where are we converting the <x-backpack::menu-item> tag to the menu?

@tabacitu
Copy link
Member

tabacitu commented Aug 14, 2023

Thanks for the investigation @karandatwani92 . So then:

  • this is NOT a bug fix, this is a feature (this wasn't possible before either)
  • this is NOT a Small (1 day) task, it's most likely become Medium (1 week) or even 2x M
  • this is still a SHOULD, I agree; maybe even borderline MUST;

This is a cool feature we could launch this month if @pxpm has the time. Otherwise we can do it next month too. We're not in a rush since Antonio is already working on a feature this month, the activity-log package.

@pxpm do you agree with the above?

@tabacitu tabacitu assigned pxpm and unassigned tabacitu Aug 14, 2023
@tabacitu tabacitu added Size: M 1 week Feature and removed Size: S 1 day Possible Bug A bug that was reported but not confirmed yet. labels Aug 14, 2023
@tabacitu tabacitu removed this from This week Aug 14, 2023
@tabacitu
Copy link
Member

tabacitu commented Sep 1, 2023

Happy to say this is DONE thanks to Pedro. You only need to define nested="true" on you sub-dropdowns in 6.2+ 😉

https://backpackforlaravel.com/docs/6.x/base-components#menu-dropdown-menu-dropdown-item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants