Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove View and Download File buttons for restricted access items #31

Open
rosanna-smith opened this issue Oct 25, 2023 · 3 comments
Open
Assignees
Milestone

Comments

@rosanna-smith
Copy link
Contributor

rosanna-smith commented Oct 25, 2023

This depends on: Language-Research-Technology/oni#2

For objects where access is restricted, the View File and Download File buttons are redundant and could be confusing. Better to just show the red permission message there. On restricted audio files (and I assume video as well) the permission message doesn't appear because Preview File is there but changes to that if you try to click it.

Example: https://data-uat.ldaca.edu.au/object?id=arcp%3A%2F%2Fname%2Cfarms-to-freeways-example-dataset%2Finterview-object%2Fpatriciacolless&_crateId=arcp%3A%2F%2Fname%2Cfarms-to-freeways-example-dataset

@rosanna-smith rosanna-smith changed the title Remove Vew and Download File buttons for restricted access items Remove View and Download File buttons for restricted access items Oct 27, 2023
@smusgrav smusgrav added this to the Version 1.6.7 milestone Oct 27, 2023
moisbo added a commit that referenced this issue Nov 1, 2023
@rosanna-smith
Copy link
Contributor Author

Looks great for text docs like csv, pdf etc! On mp3 and video it still shows preview file and if you click that then the red message appears, though it's good that the view and download options don't appear.

@moisbo
Copy link
Member

moisbo commented Nov 1, 2023

No worries. I would need to put this off because I would need to change the api to give me a 403 without downloading it

@moisbo moisbo modified the milestones: Version 1.6.7, Version 1.6.8 Nov 1, 2023
@moisbo moisbo modified the milestones: Version 1.6.8, Version 1.6.9 Jan 31, 2024
@moisbo moisbo modified the milestones: Version 1.7.0, Version 1.7.1 Mar 13, 2024
@moisbo
Copy link
Member

moisbo commented Mar 27, 2024

Not sure if related but some files only appear the Download button when after getting a Preview

@moisbo moisbo modified the milestones: Version 1.7.1, Version 2.1.0 Jun 6, 2024
@moisbo moisbo modified the milestones: Version 2.1.0, Version 2.1.1 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants