Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown predefined entity   #9

Open
kseistrup opened this issue Oct 9, 2019 · 7 comments
Open

unknown predefined entity   #9

kseistrup opened this issue Oct 9, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@kseistrup
Copy link

The latest gorss compiled from master (f7c469b) complains about https://koldfront.dk/log.rss:

error fetching url: https://koldfront.dk/log.rss, err: unknown predefined entity  

But isn't   a valid HTML entity?

@Lallassu
Copy link
Owner

Very strange, I got that error one out of 10 attempts. Not sure what's causing it. While debugging I couldn't trigger it.

I will have to dig deeper into this when I have more time. But currently it actually seems to work. Do you get that error every time?

@Lallassu Lallassu added the bug Something isn't working label Oct 13, 2019
@kseistrup
Copy link
Author

Do you get that error every time?

To be fair, I have only seen that particular error message once, but I also don't run gorss continuously: Sometimes it duplicates lines in the Feeds window, but I don't have enough data to submit a bug.

@kseistrup
Copy link
Author

I did get it a few minutes ago, though:

2019/10/13 10:46:45 rss.go:68: error fetching url: https://koldfront.dk/log.rss, err: unknown predefined entity  

@gbmor
Copy link

gbmor commented Nov 26, 2020

I happened across this somehow and decided to dig a bit. It looks like it was a bug in gofeed that was fixed. Here's the commit:

mmcdole/gofeed@22a67f9

Looks like it was decoding only certain HTML entities, and   was not one of them. So, if the version of gofeed is bumped, it should fix it here as well.

@Lallassu
Copy link
Owner

I bumped the gofeed version to 1.1.0. I couldn't trigger this error with the given feed. Not before and not after.

@kseistrup could you build a new version based on master branch and see if you can trigger this bug?

@kseistrup
Copy link
Author

It seemed to go well for the first couple of seconds, then it segfaulted:

scrot

This was 330ce3e


  • go version go1.15.5 linux/amd64
  • Linux home 5.9.10-arch1-1 OPML Support? #1 SMP PREEMPT Sun, 22 Nov 2020 14:16:59 +0000 x86_64 GNU/Linux

@Lallassu
Copy link
Owner

Strange, I can't seem to trigger that. Can you post your configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants