Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO improvements #87

Open
3 of 4 tasks
JoanneBogart opened this issue Mar 4, 2024 · 2 comments
Open
3 of 4 tasks

SSO improvements #87

JoanneBogart opened this issue Mar 4, 2024 · 2 comments
Assignees

Comments

@JoanneBogart
Copy link
Collaborator

JoanneBogart commented Mar 4, 2024

The initial SSO code has some rough edges.

  • Use of streaks. It probably is the case that we'll always want to render SSOs as streaks, not point sources. When that's confirmed, eliminate streak option (now defaulted to True) in SsoObject.get_gsobject_components
  • Don't do division by cos(dec) in SsoObject.get_gsobject_components. Either (preferred) request that Sorcha output not include this factor in ra rate or do the division just once when creating the main sky catalog
  • SED file (currently an sqlite3 db) should be in standard text format, readable by galsim. It could be included in the skyCatalogs package. (Will it always be the case that the same SED is used for all SSOs?)
  • Move hard-coded default path for SSO input (from Sorcha run) to the script create_sc.py
@JoanneBogart JoanneBogart self-assigned this Mar 4, 2024
@JoanneBogart
Copy link
Collaborator Author

Although streak is the default, there are situations where it's impossible to render a particular SSO as a streak, in which case we fall back to point source.

@JoanneBogart
Copy link
Collaborator Author

Last two items are addressed in PR #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant