Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than 1 galaxy type for API #115

Open
JoanneBogart opened this issue Aug 1, 2024 · 1 comment
Open

More than 1 galaxy type for API #115

JoanneBogart opened this issue Aug 1, 2024 · 1 comment

Comments

@JoanneBogart
Copy link
Collaborator

JoanneBogart commented Aug 1, 2024

There is no reason to create more than one galaxy type per invocation of create_sc.py - in fact normally catalogs for only one object type altogether are created at a time. But the API should be able to read catalogs for more than one type in the same session.
In order of desirability

  1. Verify this works properly now
  2. Update code to make it work
  3. Constrain users to simulate only one galaxy type per usage of skyCatalogs API
@JoanneBogart
Copy link
Collaborator Author

JoanneBogart commented Aug 30, 2024

One thing standing in the way of reading both diffsky and cosmodc2 catalogs is that, by default, they use the same file name templates: galaxy_.parquet for main file and galaxy_flux_.parquet (and are expected to be in the same directory as the config file). With current code this can probably (awkwardly) be overridden at creation time and again when reading, but it would be better to just use distinct names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant