Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lv2 plugins with no outputs should be loadable #7191

Open
1 task done
JohannesLorenz opened this issue Apr 3, 2024 · 0 comments
Open
1 task done

Lv2 plugins with no outputs should be loadable #7191

JohannesLorenz opened this issue Apr 3, 2024 · 0 comments

Comments

@JohannesLorenz
Copy link
Contributor

Enhancement Summary

Currently, a few of plugins will not load in LMMS, saying - no audio output channel (if you have LMMS_LV2_DEBUG set).

This is a missed opportunity, because those plugins could be used well.

Implementation Details / Mockup

As favored in discord, since LMMS requires to fill output buffers for all plugins, the solution is to let LMMS fill the output buffer with something sane in Lv2Proc::copyBuffersToCore, even if the plugin does not provide output via an output port. It has been agreed that in that case, the output buffer just shall mirror the values of the input buffer ("pass through").

An implementation must be careful so that for these plugins, the Lv2Proc::outPorts() function will never be called.

Please search the issue tracker for existing feature requests before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant