New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for changed native folder/file names when loading files #7186
Comments
That would be this line: Line 1113 in bb6a77a
|
The files had the BPMs added and thus have been renamed with pull request #6747 by @mirk0dex. Might be that the upgrade routine that was also provided by the PR does not work. Or something has changed later. The upgrade routine also looks needlessly complex for something that should be a straight mapping from an old name to a new one. |
The tests in the upgrade routine |
Pull request #7235 fixes the problems that have been introduced by adding the BPM values to the names. @mirk0dex, I have removed the code with regards to the Only remaining problem with the linked test file is that the "bassloopes" file is still not found. |
We had tested it thoroughly, and it worked just fine.
|
Yeah, I remember spending quite some time on it. Should apparently have spent some more time on it. :( |
The problem is that the example file that's linked above does not use The question is if the same files names with To be frank, I think renaming the samples that already exist for a long time and that are likely used in tons of projects might have been the first dangerous step in the first place. I think what LMMS could need is a dialog that opens when some samples cannot be found so that the users have a chance to efficiently point LMMS to the right sample(s). If I remember correctly in REAPER you can either specify the exact file to be used for a missing sample or point it to a directory from where it searches for samples matching by name. |
Not sure about the whole
The loops, many of which are actually pretty good, were difficult to use because it was hard to tell what their BPM was. Especially now, that we have warping-like capabilities thanks to Slicert, which doesn't always guess the right BPM, I believe the tags are needed.
+1 to this. Many programs have this feature already. |
@mirk0dex, do you have an example file at hand that has the |
Here:
zonkmachine'd created these and sent them to me for testing the routine. Edit: wait, adjusted file name? These files were not run through the routine yet. |
Thanks @mirk0dex! These files are exactly what I was asking for. 👍 |
With pull request #7236 |
System Information
Windows 10
LMMS Version(s)
master, all
Most Recent Working Version
No response
Bug Summary
Upgrade routine not working as expected on changed sample/folder names.
Files from 0.4 (pre #2712) had the bassloops folder titled "bassloopes".
Loading old project files made before this fix will throw the Sample not found error. If there was a data file routine it does not work (anymore)
At some point in 1.3 (#6747) bpm tags were added to beats in the sample folder.
Old projects do not load now, they also throw a Sample not found error.
Expected Behaviour
File upgrade routine should ensure file loads without errors of sample not found.
Steps To Reproduce
Find file linked in Screenshots / Minimum Reproducible Project.
Attempt to open it in latest master.
Logs
No response
Screenshots / Minimum Reproducible Project
Good example of file to trigger this:
https://lmms.io/lsp/?action=show&file=3625
Please search the issue tracker for existing bug reports before submitting your own.
The text was updated successfully, but these errors were encountered: