Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Jack x42/weakapi #7151

Open
1 task done
Snowiiii opened this issue Mar 20, 2024 · 1 comment
Open
1 task done

Drop Jack x42/weakapi #7151

Snowiiii opened this issue Mar 20, 2024 · 1 comment

Comments

@Snowiiii
Copy link
Contributor

Enhancement Summary

Currently we are using x42's WeakAPI to load the Jack library, We should move to the Official API

Implementation Details / Mockup

The Official API can be found here

Please search the issue tracker for existing feature requests before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@DomClark
Copy link
Member

What is the justification for doing this? We use weak JACK to avoid a hard runtime dependency on JACK, which must be installed separately and cannot be shipped with LMMS. To quote the Weak-JACK readme:

The jack shared library needs to be installed system-wide (for all jack applications to share), it can not be part of an application itself.
[...]
weak-jack linking is useful (at least) in the following cases:

  • the resulting application should not be directly linked to libjack.[so|dll|dylib] IOW: the application should start even if libjack is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants