Source File Reorganization #5944
Replies: 6 comments 10 replies
-
One thing I find a bit confusing is the subdivisions in the GUI folder. Are the exactly defined and meaningful?
I also find the src/tracks folder rather weird. These should probably move in under core after the split. Plus, we have src/core/lv2, but no src/core/vst2 or src/core/ladspa. Are these two good candidates for new folders? +1 for matching the src folder structure in the include directory. |
Beta Was this translation helpful? Give feedback.
-
Similar to what Spekular said about dialogs: In the current file tree, I often look for widget files and don't know if they are in All in all, I'm not always for creating more folders. E.g. if you have a folder for "TrackView" classes, one for menus, one for editors etc., then when you look for a gui file, you always need to think "Is it a track view? No. Is it a menu? No. Is it an editor? No" etc. . I guess I'm faster just finding all in "src/gui" and scroll to the right starting letter in my IDE... |
Beta Was this translation helpful? Give feedback.
-
With only one file, the folder I also suggest moving |
Beta Was this translation helpful? Give feedback.
-
Which classes should go in Qt has a number of classes that come in groups of three, e.g. |
Beta Was this translation helpful? Give feedback.
-
I think we should eventually separate GUI headers from core headers to a new directory( |
Beta Was this translation helpful? Give feedback.
-
https://github.com/allejok96/lmms/wiki/Widget-overview In the link above I've tried to categorize widgets based on where they are used, and what widgets they contain/are contained by.
|
Beta Was this translation helpful? Give feedback.
-
Discussion for the subtopic of source file reorganization in #5592.
include/
is a big target, we should aim for bothinclude/
andsrc/
to have the same folder structure. Additionally, we can comment on namespacing classes.I tried to make the huge list of files a little more managable (and less scroll heavy) by grouping it into collapsable groups based on folder structure. Let me know if we'd rather just have the
tree
output as-is instead./
include/
src/
excluding3rdparty
src/core/
src/core/audio/
src/core/lv2/
src/core/midi/
src/gui/
src/gui/dialogs/
src/gui/editors/
src/gui/Forms/
src/gui/menus/
src/gui/widgets/
src/tracks/
Beta Was this translation helpful? Give feedback.
All reactions