Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conduit version check is broken #25

Open
mneilly-et opened this issue Apr 30, 2024 · 1 comment
Open

Conduit version check is broken #25

mneilly-et opened this issue Apr 30, 2024 · 1 comment

Comments

@mneilly-et
Copy link

The following version check is broken when the conduit minor version > 8. E.g. - 0.9.0 fails the check.

// Determine whether Conduit has the tiled function.
#if CONDUIT_VERSION_MAJOR >= 0 && CONDUIT_VERSION_MINOR >= 8 && CONDUIT_VERSION_PATCH >= 9
#define TETON_CONDUIT_HAS_TILED_FUNCTION
#endif

Yet, the build script specifies 0.9.0 here:

git clone --recurse-submodules https://github.com/LLNL/conduit.git conduit -b v0.9.0

@BradWhitlock
Copy link
Member

You are correct. Try the following in the meantime or always define TETON_CONDUIT_HAS_TILED_FUNCTION.

#define VERSION_NUMBER(MAJOR, MINOR, PATCH) (((MAJOR) * 100 * 100) + ((MINOR) * 100) + (PATCH))
#define CONDUIT_VERSION_NUMBER VERSION_NUMBER(CONDUIT_VERSION_MAJOR, CONDUIT_VERSION_MINOR, CONDUIT_VERSION_PATCH)

// Determine whether Conduit has the tiled function.
#if CONDUIT_VERSION_NUMBER >= VERSION_NUMBER(0, 8, 9)
#define TETON_CONDUIT_HAS_TILED_FUNCTION
#endif 

In newer versions of the code (not yet released) the Conduit version checks were removed since Conduit 0.9.0 was made the minimum version used for UMT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants