Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot fetch non-existent child "relativeTolerance" from Node (options/iteration) #14

Open
cmakrides-hpe opened this issue Sep 8, 2023 · 0 comments

Comments

@cmakrides-hpe
Copy link

I think there's an error here with the relativeTolerance option being set only if a benchmark problem is specified.

options["iteration/relativeTolerance"] = 1e-10;

If one doesn't run a benchmark problem, i.e. the program isn't run with -b [0,1,2], the relativeTolerance isn't set and then I see an error when trying to read this option

terminate called after throwing an instance of 'conduit::Error' what(): file: /tmp/cmakrides/spack-stage/spack-stage-conduit-0.8.8-d7d3sdhauopbnumlex4gwzgcs4d2pvah/spack-src/src/libs/conduit/conduit_node.cpp line: 14197 message: Cannot fetch non-existent child "relativeTolerance" from Node(options/iteration)

The read that causes an error later on is from

double relative_tol = options.fetch_existing("iteration/relativeTolerance").value();

There doesn't seem to be an option to the driver that allows the tolerance to be set, so in principle a default would have to be set before the test for the benchmark problem is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant