Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Moving windows between monitors on UltrawideVerticalStack layout #833

Closed
CtByte opened this issue May 18, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@CtByte
Copy link

CtByte commented May 18, 2024

Describe the bug
When moving a window from left to right using the komorebic move right command between 2 monitors, the moved window is added to the right side of the 2nd monitor instead of the left.

This issue happens when the 2nd monitor is using the UltrawideVerticalStack layout. I also tested in 'BSP' and the window is added correctly. To the left, instead of the right.

To Reproduce
Steps to reproduce the behavior:

Dual monitor setup
image

  1. Have at least the 2nd monitors use the UltrawideVerticalStack layout
  2. Open a window on both monitors
  3. Move the window from the 1st monitor to the 2nd monitor using the komorebic move right command
  4. See bug

Expected behavior
The window coming from the 1st monitor is added to the left side of the 2nd monitor.

Screenshots and Videos

Recording.2024-05-18.174850.mp4

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\{UserName}

Looking for configuration files in C:\Users\{UserName}

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\{UserName}\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
@CtByte CtByte added the bug Something isn't working label May 18, 2024
@LGUG2Z
Copy link
Owner

LGUG2Z commented May 19, 2024

https://github.com/LGUG2Z/komorebi/blob/a29ab4cfb3458cca971d17ae87b985bb49880143/komorebi/src/window_manager.rs#L1247:L1252

The insertion position when moving across monitors depends on the last focused container index on the target monitor, and the case of UltrawideVerticalStack layout is a little more complex as the container at the index 0 occupies the largest position (in the middle) rather than the leftmost or topmost position (which is usually the largest position in other layouts)

@CtByte
Copy link
Author

CtByte commented May 19, 2024

Ah I see that is why when there are 2 windows on the 2nd monitor, a window on the 1st monitor will be placed in the middle of the workspace when moved with commands.

So I would say, let's keep it simple as this feels like more of a feature than a bug 😄

@CtByte CtByte closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants