-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential using mis-ordered KITTI prompt #21
Comments
Thanks a lot @haooooooqi for catching/reporting this! will fix that now on the code and recaculate the benchmark for KITTI. |
@haooooooqi Quick question, could you explain where you found the default order of the classes? I was trying to read VTAB's original code (https://github.com/LAION-AI/CLIP_benchmark/blob/main/clip_benchmark/datasets/kitti.py#L101), and I have trouble to understand what they were trying to do. If we follow the code and if |
Investigating further, I displayed the actual dists
so class 0 correspond indeed to <=8, class 1 to between 8 and 20, class 2 to > 20, class 3 to no vehicle (value of 1000)
It is thus intriguing that you got better results with the following order (if I understand well):
|
Hi,
Thanks so much for providing such impactful works (LAION, Open CLIP, Open CLIP benchmark) to the community!
I noticed there might be a potential use of the mis-ordered KITTI prompt from https://github.com/openai/CLIP/blob/main/data/prompts.md#kitti
The prompt shared by Open AI is:
Here is the default order of the KITTI (distance) dataset:
If we pair them:
Seems the right pair should be:
With the order chance, I can get 29.3 with the ViT-L/14 laion400m_e32 model.
Hope that could be helpful :)
Haoqi
The text was updated successfully, but these errors were encountered: