Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy constraint - can it be lifted? #160

Open
rsxdalv opened this issue Aug 4, 2024 · 3 comments
Open

numpy constraint - can it be lifted? #160

rsxdalv opened this issue Aug 4, 2024 · 3 comments

Comments

@rsxdalv
Copy link

rsxdalv commented Aug 4, 2024

https://github.com/LAION-AI/CLAP/blame/8e558817d853808486768004fa1b61ac9d69f2a2/pyproject.toml#L24

Most of the TTS/Audio projects I have use numpy >= constraints, except CLAP with ==, which is a requirement of Stable Audio Tools.

How can I test if it's still relevant, and perhaps lift this constraint?

@lukewys
Copy link
Contributor

lukewys commented Aug 5, 2024 via email

@pharmapsychotic
Copy link

This is an issue for me as well resolving dependencies with other libraries that pin numpy==1.26.4 while laion-clap pins numpy==1.23.5. It would be helpful for libraries to specify the range of versions they work with so a mutually compatible version can be selected.

@rsxdalv
Copy link
Author

rsxdalv commented Dec 5, 2024

I think the downstream project that I'm using works fine with newer numpy versions. However I still have not done a direct test of the full library API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants