fix: right click on request opens far to the right #8181 #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
filfreire
force-pushed
the
fix/right-clicking-on-a-request
branch
from
b8d9303 to
82201ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses and closes #8181.
The current behavior when right clicking on a request or request group is for the context menu to always open at the far right side of the panel:
This fix allows the context menu to open at the location of the cursor, if needed:
contextMenuPositioncatches the location of the user's cursoronContextMenuand passes it down toRequestGroupActionsDropdownorRequestActionsDropdown.setContextMenuPositionalso needs to be passed down to those components to resetcontextMenuPositiononOpenChange(eg the user instead clicks on the icon to open the dropdown).The x and y positions are then dynamically applied to the dropdown if needed.
It isn't the prettiest solution but it gets the job done. I wasn't sure how to test this, so let me know if that is a requirement.