Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record default filler removes populated fields #307

Closed
rainest opened this issue Apr 5, 2023 · 5 comments
Closed

Record default filler removes populated fields #307

rainest opened this issue Apr 5, 2023 · 5 comments

Comments

@rainest
Copy link
Contributor

rainest commented Apr 5, 2023

#302 introduced a bug that was not visible until integrated into another application.

bug.tar.gz shows a demonstration using deck. Syncing orig.yaml with the current deck release (/tmp/deck) and then diffing with a build that includes 0.39.1 shows it removing the populated config.add.headers array.

@rainest rainest mentioned this issue Apr 5, 2023
@rainest
Copy link
Contributor Author

rainest commented Apr 5, 2023

@nishant95 the change from #302 introduced a bug where it's stripping present configuration. Can you see if you can find a fix?

@nishant95
Copy link
Contributor

@rainest Sure, i'll look into it.

@nishant95
Copy link
Contributor

@rainest raised a PR #309 with the fix.

Can we add some checks so that such bugs can be detected before merging the PR?

@rainest
Copy link
Contributor Author

rainest commented Apr 7, 2023

We can't easily add consistent checks beyond the style of tests already in this repo since it'd mean running other repo's tests.

I should have run a manual replace test like Kong/kubernetes-ingress-controller#3866 earlier.

Ed: well, that's what I wanted to do, anyway. For some reason that doesn't appear to be triggering PR integration tests like it should :(

@nishant95
Copy link
Contributor

Fixed in #309

@rainest rainest closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants