-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record default filler removes populated fields #307
Comments
@nishant95 the change from #302 introduced a bug where it's stripping present configuration. Can you see if you can find a fix? |
@rainest Sure, i'll look into it. |
We can't easily add consistent checks beyond the style of tests already in this repo since it'd mean running other repo's tests. I should have run a manual replace test like Kong/kubernetes-ingress-controller#3866 earlier. Ed: well, that's what I wanted to do, anyway. For some reason that doesn't appear to be triggering PR integration tests like it should :( |
Fixed in #309 |
#302 introduced a bug that was not visible until integrated into another application.
bug.tar.gz shows a demonstration using deck. Syncing
orig.yaml
with the current deck release (/tmp/deck
) and then diffing with a build that includes 0.39.1 shows it removing the populatedconfig.add.headers
array.The text was updated successfully, but these errors were encountered: