Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the CodeMirror KCL language support to a package #4868

Open
mattmundell opened this issue Dec 26, 2024 · 0 comments
Open

Move the CodeMirror KCL language support to a package #4868

mattmundell opened this issue Dec 26, 2024 · 0 comments

Comments

@mattmundell
Copy link

mattmundell commented Dec 26, 2024

Would you be interested in splitting the language support parts of src/editor/plugins/lsp/kcl/ into a separate JS package?

Benefits:

  • other projects can use the language. Eg I wanted to play with KCL in my local CodeMirror.
  • if it's structured more like other CM langs then it'll be easier for people to contribute. Eg would make it easier for me to add tests and fix the missing = that is breaking code folding.

I've preped the package: https://github.com/cookshack/codemirror-lang-kcl. If you want to create a repo I'd be keen to make it a PR. It's basically highlight.ts, kcl.grammar and language.ts from kcl/, with the LSP parts stripped out. Also happy to make a PR to integrate the module in modeling-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant